-
Notifications
You must be signed in to change notification settings - Fork 400
Disco video #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disco video #443
Conversation
I updated the sizing on the video to 512x288 since that's half of the video's 1024x576. The border radius wasn't working with the other dimensions since there'd be whitespace on the sides so you couldn't see it. |
test: /\.jpg$/, | ||
loader: 'url?limit=10000&mimetype=image/jpeg', | ||
}, { | ||
test: /\.webm$/, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for the videos you could use the file-loader directly since these should never be inlined. The url-loader hands-off to the file-loader if the size is over the limit param.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we had a small video wouldn't we want it inlined though? I feel like the benefits would be the same as for images. I doubt we'll have a video that small but none the less.
Lgtm, we'll need to double check this when we have rtl, but it looks great. r+wc |
@pwalm does the screencast look good? |
@mstriemer Holy hell, does it ever. That looks awesome! |
I didn't like the other one so I started from scratch and used it as a guide. I think it's looking a bit cleaner.
Fixes mozilla/addons#9582.
Supersedes #430.