Fix l10n bundling #459
Merged
Fix l10n bundling #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muffinresearch
force-pushed
the
fix-l10n-bundling
branch
from
916ccdd to
89cec38
Compare
| } catch (error) { | ||
| log.error('Could not load initial redux data'); | ||
| // eslint-disable-next-line global-require, max-len | ||
| require(`bundle?name=[name]-i18n-[folder]!json!../../locale/${locale}/${appName}.json`)((jedData) => { |
There was a problem hiding this comment.
Would be nice to move this into the config but I'm not sure how to do that in a good way at the moment.
|
When I ran |
|
Maybe I didn't extract properly? |
|
I blew away my node_modules and reinstalled, then it worked. r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#9642