Skip to content

Add hsb and dsb to the config and test for orphaned locales #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2016
Merged

Add hsb and dsb to the config and test for orphaned locales #460

merged 1 commit into from
May 27, 2016

Conversation

muffinresearch
Copy link
Contributor

@coveralls
Copy link

coveralls commented May 26, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling d496593 on muffinresearch:add-hsb-dsb into d0680b7 on mozilla:master.

mstriemer
mstriemer reviewed May 26, 2016
View reviewed changes
tests/server/TestLocalesConfig.js
const basePath = config.get('basePath');

describe('Locale Config', () => {
for (const lang of langs) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use langs.forEach(() => { you should be able to avoid the warning. I don't think there's a bug here but it's probably safer. Same for below.

@mstriemer
Copy link
Contributor

r+wc

@muffinresearch muffinresearch merged commit d4bd0b4 into mozilla:master May 27, 2016
@muffinresearch muffinresearch deleted the add-hsb-dsb branch May 27, 2016 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mstriemer mstriemer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add hsb and dsb locales to the config.
3 participants
@muffinresearch @coveralls @mstriemer