Switch locale based on URL #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <IndexRoute component={DiscoPane} /> | ||
| <Route | ||
| path="/:locale/firefox/discovery/pane/:version/:platform/:compatibilityMode" | ||
| path="/:lang/firefox/discovery/pane/:version/:platform/:compatibilityMode" |
There was a problem hiding this comment.
I think this is technically a locale since we accept en-US and pt-BR.
There was a problem hiding this comment.
Throughout all the i18n scripts a lang is formatted consistently as en-US and a locale is en_US.
The lang format is what is used for the lang attribute. The locale format is used for translations and the directories of translations. All the utils provide can convert from lang to locale.
Since the url input is hyphenated it's called a lang in this case.
|
Looks good, r+wc |
muffinresearch
force-pushed
the
locale-via-url
branch
from
cf28524 to
56c827b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#9631