Skip to content

Add test to check disbleSSR config #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2016
Merged

Add test to check disbleSSR config #478

merged 1 commit into from
Jun 1, 2016

Conversation

muffinresearch
Copy link
Contributor

@muffinresearch muffinresearch commented May 31, 2016 •
edited
Loading

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7722f65 on muffinresearch:test-disabledSSR into 0241897 on mozilla:master.

@mstriemer
Copy link
Contributor

Perhaps we should only be able to set this with an environment variable? I'm not sure if that's possible though.

Remove the middleware in favour of a util func to process the router props.

Looks like this is only adding a test, is that right?

This is definitely a good idea for now. r+

@muffinresearch
Copy link
Contributor Author

Oops yeah the comment was wrong.

@muffinresearch muffinresearch merged commit 72fc975 into mozilla:master Jun 1, 2016
@muffinresearch muffinresearch deleted the test-disabledSSR branch April 3, 2019 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mstriemer mstriemer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a test to ensure no-one leaves disableSSR set to true.
3 participants
@muffinresearch @coveralls @mstriemer