Use the user's lang in API requests #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/client/core/api/test_api.js
Outdated
| .returns(mockResponse()); | ||
| return api.login({api: {}, code: 'my-code', state: 'my-state'}).then((apiResponse) => { | ||
| const lang = 'en-US'; | ||
| return api.login({api: {lang}, code: 'my-code', state: 'my-state'}).then((apiResponse) => { |
There was a problem hiding this comment.
Could take the opportunity to move the then down onto the next line for all of these.
|
I'm fine with leaving the attribute lookup stuff if it keeps it simple. Nice, r+wc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed pulling the lang from the state instead of
html[lang]on the client but using the attribute is pretty straightforward and taking it from state means we should be checkinginitialState && initialState.api && initialState.api.lang || config.get('defaultLang')which seems crazy. We could of course just use it but that seems like it could bite us.Fixes mozilla/addons#9540.