Centre the content in about:addons #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/disco/css/App.scss
Outdated
| font-size: 14px; | ||
| // Firefox adds this margin to the left side, for some reason we only need to add half of it. | ||
| $firefox-margin: 48px; | ||
| margin-right: $firefox-margin / 2; |
There was a problem hiding this comment.
Probably because you're adding it to the body and html.
There was a problem hiding this comment.
And this is why you don't make changes at midnight. Thanks.
|
Just putting the margin on the body now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why only half of the margin is required, but it is.
Fixes mozilla/addons#9655.