Open see more add-ons in new tab #503
Conversation
src/disco/containers/DiscoPane.js
Outdated
| {results.map((item, i) => <Addon {...camelCaseProps(item)} key={i} />)} | ||
| <div className="amo-link"> | ||
| <a href="https://addons.mozilla.org/">{i18n.gettext('See more add-ons!')}</a> | ||
| <a href="https://addons.mozilla.org/" target="_blank"> |
There was a problem hiding this comment.
We could add rel="noreferrer" which gives us the same effect as rel="noopener"
There was a problem hiding this comment.
Here's a demo since Matias' page doesn't have one: http://staticfil.es/moz/opener.html
There was a problem hiding this comment.
I suppose this is being very paranoid since we own the destination but still.
/me puts on tinfoil hat
There was a problem hiding this comment.
I was thinking we might want to log that they came from the disco pane. Maybe that logging is better off in here though?
There was a problem hiding this comment.
Yeah that would get implicitly logged via UA I would think. E.g. should show up as an exit page.
There was a problem hiding this comment.
Is that a good thing then or should I still add the noreferrer?
|
Nice catch, I wondered about this and then totally forgot to test it under the iframe. r+wc |
Without this the page won't load since it isn't on
discovery.addons.mozilla.org.