Skip to content

Conversation

muffinresearch
Copy link
Contributor

@muffinresearch muffinresearch commented Jun 2, 2016

Fixes mozilla/addons#9619

  • Unifies all the locale commands to require NODE_APP_INSTANCE
  • Adds docs for the commands

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8ddc896 on muffinresearch:add-docs-for-i18n into 0966fc7 on mozilla:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c6fb852 on muffinresearch:add-docs-for-i18n into 0966fc7 on mozilla:master.

}
potFile = path.join(templateDir, `${appName}.pot`);
poFile = path.join(localeDir, locale, 'LC_MESSAGES', `${appName}.po`);
rewrite = locale === 'dbl' ? 'unicode' : 'flipped';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is old but it's always bugged me. I'd rather see something like:

const debugLocales = [
  ['dbl', 'unicode'],
  ['dbr', 'flipped'],
];
for ([locale, rewrite] of debugLocales) {
  // ...
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's not enough es6 capability to do this since these are just node scripts.

@mstriemer
Copy link
Contributor

Thanks for documenting it! r+wc

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 66588ad on muffinresearch:add-docs-for-i18n into c254967 on mozilla:master.

@muffinresearch muffinresearch merged commit b7bcca3 into mozilla:master Jun 2, 2016
@muffinresearch muffinresearch deleted the add-docs-for-i18n branch June 2, 2016 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the localisation processes involved in the addons-frontend project
3 participants