Skip to content

Remove sprintf and use the same one that's in Jed #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2016
Merged

Remove sprintf and use the same one that's in Jed #515

merged 1 commit into from
Jun 3, 2016

Conversation

muffinresearch
Copy link
Contributor

@muffinresearch muffinresearch commented Jun 2, 2016 •
edited
Loading

Fixes mozilla/addons#9667

Makes a small difference to the disco bundle size:

  • Before: 430K dist/disco-f0233826549f9800cc0e.js
  • After: 427K dist/disco-3e774a55dcfc1db745f9.js

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f346283 on muffinresearch:reduce-sprintfs into f77295d on mozilla:master.

@mstriemer
Copy link
Contributor

r+

@muffinresearch muffinresearch merged commit 4a08338 into mozilla:master Jun 3, 2016
@muffinresearch muffinresearch deleted the reduce-sprintfs branch June 3, 2016 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mstriemer mstriemer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check if removing the extra sprintf makes a difference.
3 participants
@muffinresearch @coveralls @mstriemer