Refactor addon manager #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muffinresearch
force-pushed
the
refactor-addonmanager
branch
from
219eb16 to
566c927
Compare
src/disco/addonManager.js
Outdated
| return _mozAddonManager.getAddonByID(guid) | ||
| .then((addon) => { | ||
| if (!addon) { | ||
| return Promise.reject(new Error('Addon not found')); |
There was a problem hiding this comment.
You just moved this but I think this could throw/return instead.
if (!addon) {
throw new Error('Addon not found');
}
return addon;
muffinresearch
force-pushed
the
refactor-addonmanager
branch
from
566c927 to
bf89920
Compare
src/disco/addonManager.js
Outdated
| if (!addon) { | ||
| throw new Error('Addon not found'); | ||
| } | ||
| return Promise.resolve(addon); |
There was a problem hiding this comment.
This can just return addon.
There was a problem hiding this comment.
Yep - good catch!
|
r+wc Thanks! |
muffinresearch
force-pushed
the
refactor-addonmanager
branch
from
bf89920 to
a19ae44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the addon manager to not be a class.