Use error overlay for errors (fixes #395) #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| export function getFakeI18nInst() { | ||
| return { | ||
| gettext: sinon.stub(), | ||
| gettext: sinon.spy((str) => str), |
|
r+wc |
|
I put 5px of padding on the close button so it's a bit easier to click. Still no animation on the overlay appearing, will wait for feedback from @pwalm first. |
|
BRING ON THE ANIMATION! That looks sweet. But how about when the user turns on the switch, it turns back off (due to whatever error) and then the error animates in. That way the user will see that the switch didn't work before the error pops up. |
|
Oh and good call on the 5px of padding 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a little animation on the overlay at first but getting it to animate out was tricky so I removed it. It appears quite abruptly so we should probably add something but I'll let @pwalm say what. Maybe worth noting that I barely missed the close button there and it didn't register my click. I guess we should make that clickier.
Fixes mozilla/addons#9611.