Skip to content

Conversation

muffinresearch
Copy link
Contributor

@muffinresearch muffinresearch commented Jun 8, 2016

Fixes: mozilla/addons#9690
Fixes: mozilla/addons#9689

Before:

discover_add-ons

After:

discover_add-ons

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 37f970e on muffinresearch:fix-errant-install-button-styles into 9b27874 on mozilla:master.

@mstriemer
Copy link
Contributor

These changes look good. It looks like the switch is animating over by changing the left value. Would a translateX($size) work there instead? That should make it render more smoothly. Also I've noticed that sometimes the animation janks a little and the border turns green and then the background does, is a transition missing on the border?

r+wc

@muffinresearch
Copy link
Contributor Author

I'll land this one, and do a new issue to tune up the animation - good points. Thanks!

@muffinresearch muffinresearch merged commit 84b7523 into mozilla:master Jun 8, 2016
@muffinresearch muffinresearch deleted the fix-errant-install-button-styles branch June 8, 2016 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants