Skip to content

Use translateX for transitions #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2016
Merged

Use translateX for transitions #561

merged 1 commit into from
Jun 9, 2016

Conversation

muffinresearch
Copy link
Contributor

@muffinresearch muffinresearch commented Jun 8, 2016 •
edited
Loading

Fixes mozilla/addons#9691
Fixes mozilla/addons#9694

  • Use translateX for slide transitions (there's a bit of a double bounce for themes but I think that's state change related).
  • Transition the borders. (this fixes the weird problem with jank when the theme install bar appears see Install switch moves when turning on addons#9694).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 875353e on muffinresearch:fix-transitions into df09735 on mozilla:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6462526 on muffinresearch:fix-transitions into df09735 on mozilla:master.

@muffinresearch muffinresearch mentioned this pull request Jun 9, 2016
Closed
@muffinresearch
Copy link
Contributor Author

@mstriemer, I'm going to land this - let me know if you have any comments - for post-merge fixups.

@muffinresearch muffinresearch merged commit 30e6742 into mozilla:master Jun 9, 2016
@muffinresearch muffinresearch deleted the fix-transitions branch June 9, 2016 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mstriemer mstriemer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install switch moves when turning on Check install button animation for improvements
3 participants
@muffinresearch @coveralls @mstriemer