Skip to content

Conversation

muffinresearch
Copy link
Contributor

@muffinresearch muffinresearch commented Jun 9, 2016

Fixes mozilla/addons#9681

The UNINSTALLING restart case only occurs if someone clicks remove from about:addons#Extensions. Handling the user clicking undo is covered by mozilla/addons#9693.

Both kinds of restart look like this:

add-ons_manager

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling bfc6be9 on muffinresearch:restart-ui into 56cd0c5 on mozilla:master.

top: 0;

&.error {
background: #c33c32 url('../img/warning.svg') no-repeat calc(100% - 40px) 50%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will webpack inline these or do they need to be required?

Copy link
Contributor Author

@muffinresearch muffinresearch Jun 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it should inline it automagically since it's tiny.

@mstriemer
Copy link
Contributor

Do we see the needsRestart state on a reload? Should you be able to close the UNINSTALLING notice? You could presumably uninstall by accident and want to install again.

r+wc

@muffinresearch
Copy link
Contributor Author

Do we see the needsRestart state on a reload?

No, since we don't get that hint from the introspection. I'm not sure if that would be an issue or not.

Should you be able to close the UNINSTALLING notice? You could presumably uninstall by accident and want to install again.

It's possible we could have an undo instead of close, since the unstalling state is still pending. It'll certainly be worth looking at that separately. I'll file a new issue to cover that. Maybe 'undo' could work for all restart cases?

@muffinresearch muffinresearch merged commit 7d4964f into mozilla:master Jun 9, 2016
@mstriemer
Copy link
Contributor

If it is needsRestart then the state should be INSTALLING or UNINSTALLING, right? I think we could just do the opposite in the case of an undo, good call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement restart UI
3 participants