Skip to content

Animate the overlays (fixes #570) #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2016
Merged

Animate the overlays (fixes #570) #576

merged 1 commit into from
Jun 9, 2016

Conversation

mstriemer
Copy link
Contributor

error-overlay-full-animation mov

needs-restart-overlay mov

I just guessed at a timing function, happy to change it. I manually changed the classes for the needs restart overlay, hence why the text is wrong.

@pwalm
Copy link
Contributor

pwalm commented Jun 9, 2016

Love it! Ship it!

@mstriemer mstriemer assigned muffinresearch and unassigned pwalm Jun 9, 2016
@muffinresearch
Copy link
Contributor

Shiny r+

@mstriemer mstriemer merged commit a0d9db3 into mozilla:master Jun 9, 2016
@mstriemer mstriemer deleted the overlay-animation-570 branch June 9, 2016 18:17
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c520bde on mstriemer:overlay-animation-570 into 2fa4398 on mozilla:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@muffinresearch muffinresearch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mstriemer @pwalm @muffinresearch @coveralls