Add in-page showInfo dialog #671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // The keys listed here will be exposed on the client. | ||
| // Since by definition client-side code is public these config keys | ||
| // must not contain sensitive data. | ||
| clientConfigKeys: [ |
There was a problem hiding this comment.
Added a copy of this to disco pane so we can add disco specific keys to it.
muffinresearch
force-pushed
the
page-notification
branch
2 times, most recently
from
b217389 to
27a985e
Compare
src/disco/components/InfoDialog.js
Outdated
| aria-labelledby="show-info-title" aria-describedby="show-info-description"> | ||
| <div className="info"> | ||
| <div className="logo"> | ||
| <img src={imageURL} alt="" width="48" height="48" /> |
There was a problem hiding this comment.
Can these not be set with CSS?
There was a problem hiding this comment.
Good question. They provide a layout hint [1] but I think moving this to the CSS is just as
good [2] so I'll do that (plus it's more consistent with what we've already done).
[1] http://jsbin.com/basixugebe/edit?html,css,js,output
[2] http://jsbin.com/qofife/edit?html,css,js,output
|
Looks good to me. If you can remove the inline height/width on the image that'd be great. r+wc |
muffinresearch
force-pushed
the
page-notification
branch
from
27a985e to
8eb9ea4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#9720
Looks like this: