Enable disabled Add-ons #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| icon: iconUrl, | ||
| title: i18n.gettext('Your add-on is ready'), | ||
| text: i18n.sprintf( | ||
| i18n.gettext('Now you can access %(name)s from the toolbar.'), |
There was a problem hiding this comment.
This "s" in %(name)s is intentional, right? It seems off but maybe I don't get what name will be set to...
There was a problem hiding this comment.
Looking through it seems not. 🤔
There was a problem hiding this comment.
It's sprintf format [1] - we're using sprintf via jed [2] for localization substitutions. The 2nd arg is on the line below.
[1] http://www.diveintojavascript.com/projects/javascript-sprintf
[2] https://slexaxton.github.io/Jed/
There was a problem hiding this comment.
Ooooohhhh okay yeah I should've realised.
Cool, all good, then. My r+wc is now just an r+ 😄
|
r+wc Code looks good and everything, just not sure about the contents of that string 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#9685
DISABLEDandENABLEDfirst-class states rather than being aliased.ENABLEDshares the same styles as installed.