Prevent build and start without NODE_APP_INSTANCE #708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muffinresearch
force-pushed
the
make-start-blow-up-no-app
branch
from
e4a6c34 to
2727803
Compare
bin/build-checks.js
Outdated
| const appName = config.get('appName'); | ||
|
|
||
| // Bail if appName isn't set unless explicitly enabled. | ||
| if (!appName && parseInt(process.env.ADDONS_FRONTEND_BUILD_ALL, 10) !== 1) { |
There was a problem hiding this comment.
I think process.env.ADDONS_FRONTEND_BUILD_ALL !== '1' would be clearer. Is there a reason you need to convert to int?
|
r+wc |
muffinresearch
force-pushed
the
make-start-blow-up-no-app
branch
from
2727803 to
e03d9b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents
npm run buildandnpm run startfrom running without setting the name of the app viaNODE_APP_INSTANCE.Building all the apps is allowed with a special env var, this is because server tests still currently need to build all apps.