Add docs re: component translation #775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/i18n.md
Outdated
|
|
||
| The translation provider is used to pass down a Jed instance via context to | ||
| components lower down in the component hierarchy. This part is already done | ||
| for you in the addons-frontend code-base. So you should only need to worry |
There was a problem hiding this comment.
"code-base" seems odd to me.
"This part is already done for you in addons-frontend" would be fine.
|
r+wc |
muffinresearch
force-pushed
the
add-docs-for-translations
branch
from
6f00ef1 to
ad8e7b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#9666