Skip to content

Fix RESERVED_FILENAME message construction. #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 29, 2019
Merged

Fix RESERVED_FILENAME message construction. #2617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df2e450
Fix RESERVED_FILENAME message construction.
EnTeQuAk May 29, 2019
1df85f2
Fix test for message
EnTeQuAk May 29, 2019
ac87ccc
Make use of .toMatch for better error reporting
EnTeQuAk May 29, 2019
9628929
Fix eslint
EnTeQuAk May 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/messages/layout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ export const COINMINER_USAGE_DETECTED = {

export const RESERVED_FILENAME = {
code: 'RESERVED_FILENAME',
message: i18n._(oneLine`Files whose names are reserved have been found in
message: i18n._('Reserved filename found.'),
description: i18n._(oneLine`Files whose names are reserved have been found in
the add-on. Please refrain from using them and rename your files.`),
};
4 changes: 4 additions & 0 deletions tests/unit/scanners/test.filename.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,10 @@ describe('Reserved file names', () => {
const { linterMessages } = await filenameScanner.scan();
expect(linterMessages.length).toEqual(1);
expect(linterMessages[0].code).toEqual(messages.RESERVED_FILENAME.code);
expect(linterMessages[0].message).toEqual('Reserved filename found.');
expect(linterMessages[0].description).toMatch(
/^Files whose names are reserved/
);
expect(linterMessages[0].file).toEqual(filePath);
});
});
Expand Down