Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/parsers/installrdf.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export default class InstallRdfParser {
name: this._getName(),
type: this._getAddonType(),
version: this._getVersion(),
restartless: this._getIsBootstrapped(),
});
}

Expand Down Expand Up @@ -99,6 +100,11 @@ export default class InstallRdfParser {
return addonType;
}

_getIsBootstrapped() {
return this._getNodeValue(
this._getTopLevelNodeByTag('em:bootstrap')) === 'true';
}

_getGUID() {
// Install.rdf only.
var guid = this._getNodeValue(this._getTopLevelNodeByTag('em:id'));
Expand Down
1 change: 1 addition & 0 deletions src/parsers/manifestjson.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export default class ManifestJSONParser {
name: this._getName(),
type: this._getType(),
version: this._getVersion(),
restartless: true, // All web extensions are restartless
});
}

Expand Down
59 changes: 59 additions & 0 deletions tests/parsers/test.installrdf.js
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,65 @@ describe('InstallRdfParser._getGUID()', function() {

});

describe('InstallRdfParser._getIsBootstrapped()', () => {
it('should extract that the addon is restartless', () => {
var rdf = validRDF('<em:bootstrap>true</em:bootstrap>');
var rdfScanner = new RDFScanner(rdf, INSTALL_RDF);
return rdfScanner.getContents()
.then((xmlDoc) => {
var installRdfParser = new InstallRdfParser(xmlDoc);
return installRdfParser._getIsBootstrapped();
})
.then((bootstrap) => {
assert.typeOf(bootstrap, 'boolean');
assert.equal(bootstrap, true);
});
});

it(`should extract that the addon isn't restartless`, () => {
var rdf = validRDF('<em:bootstrap>false</em:bootstrap>');
var rdfScanner = new RDFScanner(rdf, INSTALL_RDF);
return rdfScanner.getContents()
.then((xmlDoc) => {
var installRdfParser = new InstallRdfParser(xmlDoc);
return installRdfParser._getIsBootstrapped();
})
.then((bootstrap) => {
assert.typeOf(bootstrap, 'boolean');
assert.equal(bootstrap, false);
});
});

it(`should extract only the top level bootstrap value`, () => {
var rdf = validRDF(`<em:bootstrap>true</em:bootstrap><Description>
<em:bootstrap>false</em:bootstrap></Description>`);
var rdfScanner = new RDFScanner(rdf, INSTALL_RDF);
return rdfScanner.getContents()
.then((xmlDoc) => {
var installRdfParser = new InstallRdfParser(xmlDoc);
return installRdfParser._getIsBootstrapped();
})
.then((bootstrap) => {
assert.typeOf(bootstrap, 'boolean');
assert.equal(bootstrap, true);
});
});

it(`should assume that an addon isn't restartless`, () => {
var rdf = validRDF('<em:id>123</em:id>');
var rdfScanner = new RDFScanner(rdf, INSTALL_RDF);
return rdfScanner.getContents()
.then((xmlDoc) => {
var installRdfParser = new InstallRdfParser(xmlDoc);
return installRdfParser._getIsBootstrapped();
})
.then((bootstrap) => {
assert.typeOf(bootstrap, 'boolean');
assert.equal(bootstrap, false);
});
});
});

describe('InstallRdfParser._getDescriptionNode()', function() {

it('should reject on missing RDF node', () => {
Expand Down