-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CinderPolicy model and sync_cinder_policies management command #21773
Conversation
Oh, while you're at it, to help debugging, consider adding a simple def __str__(self):
return self.name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have anything to add beyond Mat's review. My merging of another PR has caused a merge conflict in this patch though.
122cb24
to
41632bd
Compare
There is a conflicting migration as well. Recreating mine. |
How did this not trigger a CI error? @diox any ideas? I suppose our linter isn't actually tracking dependencies? Should that be the case? Feels wrong. |
You didn't have a test covering the management command, so that didn't break CI |
Fixes: mozilla/addons#9434
Description
update CinderPolicy to make uuid unique and add parent field for nesting. On a separate commit to be cherry pickable if we want to push early/separately
add a task/command to sync cinder policies to our database.
Context
Since we want to be able to trigger this either via manage.py or via cron a task seemed appropriate. There are many opinions about when to use tasks so happy to hear feedback.
Testing
make shell
./manage.py sync_cinder_policies