Integrate potools, add rtl support to debug #5455
Conversation
| msgstr "pɐoʅuʍoᗡ" | ||
|
|
||
| #. L10n: please keep in the string so → does not wrap. | ||
| msgid "Continue to Download →" |
There was a problem hiding this comment.
Need to handle this in potools. It's not the end of the world but would be good to make it ignore HTML entities.
There was a problem hiding this comment.
This one is covered by mozilla/potools#4
There was a problem hiding this comment.
This is fixed already - just needs a release.
locale/dbr/LC_MESSAGES/django.po
Outdated
| "popular pages on our website.</p> <ul> <li>Are you interested in a <a href=\"%(rec)s\">list of featured add-ons</a>?</li> <li> Do you want to <a href=\"%(search)s\">search for add-ons</a>? You may " | ||
| "go to the <a href=\"%(search)s\">search page</a> or just use the search field above. </li> <li> If you prefer to start over, just go to the <a href=\"%(home)s\">add-ons front page</a>. </li> </ul>" | ||
| msgstr "" | ||
| "<ul> <li> .<a href=\"%(home)s\">ǝƃɐd ʇuoɹɟ suo-ppɐ</a> ǝɥʇ oʇ oƃ ʇsnɾ ´ɹǝʌo ʇɹɐʇs oʇ ɹǝɟǝɹd noʎ ɟI </li> <li> .ǝʌoqɐ pʅǝıɟ ɥɔɹɐǝs ǝɥʇ ǝsn ʇsnɾ ɹo <a href=\"%(search)s\">ǝƃɐd ɥɔɹɐǝs</a> ǝɥʇ oʇ oƃ " |
There was a problem hiding this comment.
This is an example of what could be handled better, it would be nice if only the child elements with text were re-ordered. Without having the H1 at the end. It should maybe only reverse the children if there's a text-node + html mix. I'll think about how to handle that.
There was a problem hiding this comment.
I've filed mozilla/potools#5 to deal with this.
There was a problem hiding this comment.
Ok also done - 0.0.4 is on its way.
There was a problem hiding this comment.
Found another small bug so 0.0.5 is the release to try 👍
|
@muffinresearch updated to potools 0.0.5 and regenerated the files. Lots of the mentioned issues seem to be gone now. Mind a re-r? |
locale/it/LC_MESSAGES/django.po
Outdated
| @@ -7605,7 +7605,7 @@ msgid "Continue using Firefox as you normally would. Depending on how you use th | |||
| msgstr "Potrai continuare a utilizzare Firefox come al solito. A seconda delle tue abitudini di navigazione, potresti addirittura non notare differenze." | |||
|
|
|||
| msgid "After a few weeks, the study will end on its own. Your Firefox will go back to normal." | |||
| msgstr "Dopo alcune settimane l’indagine terminerà automaticamente e Firefox riprenderà ad essere quello di sempre.\n" | |||
| msgstr "Dopo alcune settimane l’indagine terminerà automaticamente e Firefox riprenderà ad essere quello di sempre." | |||
There was a problem hiding this comment.
Is this supposed to be part of the commit?
There was a problem hiding this comment.
Not really, I was under the impression I had it in a different PR already… but apparently not… might get re-done in a separate PR later.
There was a problem hiding this comment.
backed that change out
| @@ -6,12 +6,18 @@ | |||
| "node": ">= 6.0.0", | |||
| "npm": ">= 3.0.0" | |||
| }, | |||
| "scripts": { | |||
| "potools": "potools" | |||
There was a problem hiding this comment.
This is a smart solution to getting to the bin files without needing to point to node_modules 👍
|
I think this looks good - is the problem that was seen on -dev resolved? r+wc |
Fixes #2817
EnTeQuAk
force-pushed
the
feature/2817-integrate-potools
branch
from
c796896
to
cc3b0ec
Compare
Yes, the problem got fixed mainly in ceac149 |
Fixes mozilla/addons#3179