This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Async subscribe #107
Merged
Async subscribe #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Osmose
force-pushed
the
async-subscribe
branch
from
d52c7bb
to
89f9576
Compare
| @@ -673,7 +669,7 @@ def confirm_user(token, user_data): | |||
| """ | |||
| # Get user data if we don't already have it | |||
| if user_data is None: | |||
| from .views import get_user_data # Avoid circular import | |||
| from .utils import get_user_data # Avoid circular import | |||
There was a problem hiding this comment.
Is the circular import still a concern after moving this function?
There was a problem hiding this comment.
It was before I moved the one import from tasks to the inside of a function in utils. Now it's not.
added 2 commits
October 1, 2014 16:39
Includes rewritten tests for the view and utility function.
Osmose
force-pushed
the
async-subscribe
branch
from
89f9576
to
ec2d2eb
Compare
|
Updated and rebased. |
|
This looks good to me. Huge +1 for not only fixing the bug but doing some much needed reorganization of the code. 🍰 👏 |
|
|
pmclanahan
pushed a commit
that referenced
this pull request
Oct 2, 2014
Fix bug 1047002: Async subscribe
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the subscribe endpoint to avoid creating a user account within the view if
syncis set toN, instead creating the user during the delayed task.In order to make the code I was changing a little cleaner, I also happened to move all the utility functions out of
views.pyand intoutils.py. I fixed up the tests to pass, and re-wrote the tests for thesubscribeview as well as theupdate_user_taskutility function because sorting through the existing tests (which sort've tested the view, task, and utility all at once) was proving too difficult. Apologies if that makes this hard to follow; I tried to separate the correct things into the two commits to help review.@pmclanahan r?