Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

Fix bug 1088779: Fix ET error handling around views and tasks. #120

Merged
merged 1 commit into from
Oct 28, 2014

Conversation

pmclanahan
Copy link

This refactors a lot about how ET errors are handled. They were being
converted to dicts of error information which needed to be detected and
dealt with by calling functions. Now they raise exceptions with proper
information attached that can bubble up in tasks to cause retries, or be
converted to error reponses in views.

This refactors a lot about how ET errors are handled. They were being
converted to dicts of error information which needed to be detected and
dealt with by calling functions. Now they raise exceptions with proper
information attached that can bubble up in tasks to cause retries, or be
converted to error reponses in views.
@pmclanahan
Copy link
Author

@jgmize wow. So basket code needs a lot of work, but this should help some.

I think the explanation above makes sense, but ping me if not. I was just going to find spots where it should look for user_data['status'] == 'error' and raise an exception or convert to error JSON reponse, but a full on refactor soon followed.

r?

jgmize added a commit that referenced this pull request Oct 28, 2014
…8779

Fix bug 1088779: Fix ET error handling around views and tasks.
@jgmize jgmize merged commit c78d28a into mozilla:master Oct 28, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants