Remaining changes required to get the app running on Heroku. #147
Conversation
|
It looks like redis is currently required for the tests to pass, but it was moved to requirements/prod.txt, which travis doesn't currently install. |
pmclanahan
force-pushed
the
heroku-style
branch
from
62a63e4
to
6bf4a75
Compare
I think this is an indication that we should use a mock EmailAddress in https://github.com/mozilla/basket/blob/master/news/tests/test_email.py#L30-L39 instead of importing flanker, and we should also either make redis an explicit dependency even in dev or change it to use a different driver in dev. |
pmclanahan
force-pushed
the
heroku-style
branch
from
6bf4a75
to
3a44719
Compare
pmclanahan
force-pushed
the
heroku-style
branch
from
3a44719
to
58ba939
Compare
|
Bah! We're not even using flanker now because of too many false negatives. I think the best thing for now is to remove it completely and revisit email address verification later. |
Includes up-to-date data, so we no longer need it in the repo.
pmclanahan
force-pushed
the
heroku-style
branch
from
deb3bfd
to
eb1c46f
Compare
|
Closing this in favor of docker-style, which will be based on this work. |
Mostly this is for safe keeping and needs some cleaning, but if a bit of review happened I wouldn't be sad.