This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Fix bug 1261465: Send recover message only in supported languages #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -787,13 +787,6 @@ def attempt_fix(ext_name, record, task, e): | |||
|
|
|||
| @et_task | |||
| def send_recovery_message_task(email): | |||
| # Have to import here to avoid circular import - that means that for | |||
| # testing, this can't be mocked. Mock look_for_user instead. | |||
| from news.views import get_user_data | |||
There was a problem hiding this comment.
Why is the circular import described in the comment above no longer an issue?
There was a problem hiding this comment.
Because the function was moved to utils.py and it seems this task was just never fixed. This was part of the upgrade to Django 1.8. It's imported at the top of the file and used by other tasks now.
If user language is not supported send english. Also clean up the task a bit.
pmclanahan
force-pushed
the
fix-recovery-task-1261465
branch
from
68dd654
to
b1c5be5
Compare
|
w00t! Tests fixed and one added. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user language is not supported send english. Also clean up the task a
bit.