This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Fix bug 1011001: Add support for optin param back to subscribe. #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Osmose feel like r? some Basket :) |
| @@ -120,7 +120,8 @@ The following URLs are available (assuming "/news" is app url): | |||
| "newsletters" field, which should be a comma-delimited list of | |||
| newsletters. "email" and "newsletters" are required. "optin" should | |||
| be Y or N depending if the user should automatically be opted in, | |||
| default is Y. "trigger_welcome" should be Y to fire off a welcome email:: | |||
| default is N and setting Y requires a valid API key. "trigger_welcome" | |||
There was a problem hiding this comment.
Future improvement suggestion: Explain what opting in means. :P
|
r+. The additional test would be nice, the other two are just random thoughts. Nice work! |
|
@Osmose updated. mind taking another look? |
|
Well... We're planning a push soon, so I'll get this in. If you have opinions on things further I'll send another PR. Thanks again! |
* Fix flake8 issue. Add flake8 config. * Improve optin documentation in README and doc string. * Also add some case-insensitivity tests.
|
Luckily for you it looks great so that I have no more input! :P |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting optin=Y will now require an API key and SSL to avoid people
being signed up without a confirmation step.