-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GA session_id to stub attribution data (Fixes #12355) #12794
Conversation
b710f49
to
82186b2
Compare
82186b2
to
09ef948
Compare
Hey, so this PR has been verified by QA and we update the stub service on production. Alex, you can go ahead with this PR now, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few lingering references to visit ID but nothing blocking.
Co-authored-by: Stephanie Hobson <sjhobson@gmail.com>
Co-authored-by: Stephanie Hobson <sjhobson@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #12794 +/- ##
==========================================
+ Coverage 76.75% 76.88% +0.12%
==========================================
Files 144 144
Lines 7674 7669 -5
==========================================
+ Hits 5890 5896 +6
+ Misses 1784 1773 -11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
One-line summary
session_id
parameter to stub attribution that contains the GA session ID.visit_id
toclient_id
as to be more technically correct / less confusing.Significant changes and points to review
This change has already been tested end-to-end by QA against demo3, so code-level review should be all that's really required here. If you would like to manually test things still, there are testing steps below for the bedrock side of things.
Issue / Bugzilla link
#12355
Testing
moz-stub-attribution-code
. The value should be a base64 string.client_id
andsession_id
parameter.