Skip to content

Conversation

ilanasegall
Copy link
Contributor

@ilanasegall ilanasegall commented Sep 18, 2025

Description

Reviewer, please follow this checklist

@dataops-ci-bot

This comment has been minimized.

@dataops-ci-bot
Copy link

Integration report for "Merge branch 'main' into ilanasegall-patch-2"

sql.diff

Click to expand!
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop_derived/report_content_v1/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop_derived/report_content_v1/query.sql
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop_derived/report_content_v1/query.sql	2025-09-23 23:22:47.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop_derived/report_content_v1/query.sql	2025-09-23 23:19:53.000000000 +0000
@@ -10,12 +10,12 @@
     mozfun.map.get_key(event.extra, 'topic') AS topic,
     mozfun.map.get_key(event.extra, 'url') AS url
   FROM
-    `moz-fx-data-shared-prod.firefox_desktop.newtab` AS e
+    `moz-fx-data-shared-prod.firefox_desktop.newtab_content` AS e
   CROSS JOIN
     UNNEST(e.events) AS event
   WHERE
     DATE(submission_timestamp) = @submission_date
-    AND event.category = 'newtab'
+    AND event.category = 'newtab_content'
     AND event.name = 'report_content_submit'
 )
 SELECT

Link to full diff

Copy link
Contributor

@chelseybeck chelseybeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ilanasegall ilanasegall added this pull request to the merge queue Sep 23, 2025
Merged via the queue into main with commit bed799d Sep 24, 2025
22 checks passed
@ilanasegall ilanasegall deleted the ilanasegall-patch-2 branch September 24, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants