Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Nits on the Blok bar #99

Closed
3 of 5 tasks
johngruen opened this issue Aug 9, 2016 · 4 comments
Closed
3 of 5 tasks

Style Nits on the Blok bar #99

johngruen opened this issue Aug 9, 2016 · 4 comments
Labels

Comments

@johngruen
Copy link
Contributor

johngruen commented Aug 9, 2016

screen shot 2016-08-08 at 1 43 52 pm
screen shot 2016-08-09 at 12 22 15 pm
screen shot 2016-08-09 at 12 26 17 pm

  • Font weights onon the buttons should be normal, not bold
  • type should be vertically aligned in the buttons, and on the bar...currently too high
  • consider using flexbox for aligning content
  • button height appears smaller than buttons in other notification bars.
  • link color is an accessibility problem. consider underlined an underlined white link
@johngruen johngruen changed the title Font Nits on the Blok bar Style Nits on the Blok bar Aug 9, 2016
@groovecoder
Copy link
Member

Should these block the launch?

@groovecoder
Copy link
Member

I'm putting launch blockers in the https://github.com/mozilla/blok/milestone/1

@groovecoder
Copy link
Member

Hit 3/5 of these with #102 ... Might file a follow-up issue for flexbox (I know nothing about it), and not sure the button height has to match exactly to other toolbars?

groovecoder added a commit that referenced this issue Aug 11, 2016
@groovecoder
Copy link
Member

Closing this since we plan to change the toolbar into a page action. #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants