var vs let vs const, oh my!

[pdehaan]

We have arguments against const and arguments for const, let's have a 🔪 and 🔫 fight and settle this once and for all and see if we can find an ESLint rule that will support whatever we go with.

So this is a "needs discussion" but now shouldn't be a blocker on the current open PR.

[groovecoder]

If only one of them can be enforced via eslint that will probably make up my mind. @pdehaan do you know if eslint can support one of these and not the other?

[nhnt11]

I believe the prefer-const rule can do this. Happy to submit a PR when I'm back at my desk.

…

On Feb 13, 2018 10:05 PM, "luke crouch" ***@***.***> wrote: If only one of them can be enforced via eslint that will probably make up my mind. @pdehaan <https://github.com/pdehaan> do you know if eslint can support one of these and not the other? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#46 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAdocA4Yp9EXkCA1jbwDeybE41nL-iKQks5tUbm5gaJpZM4SClB8> .

[pdehaan]

Only one I'm aware of is prefer-const, which will try and make everything a const if it is never reassigned. Plus, it will try and make every for..in and for..of loop a const (which isn't a problem, but IIRC Firefox had a bug about that a long time ago, although is a Node-only app for now). Although we could override specific instances by littering // eslint-disable-next-line prefer-const if we wanted.

[pdehaan]

@nhnt11 I enabled prefer-const in #47 PR, but then stupidly threw a bunch of other unrelated tweaks in the PR while I was at it.

[pdehaan]

Does anybody have any mild/strong objections to our current let vs const decisions, or can we close this issue?

[nhnt11]

Let's close this.