Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @playwright/test from 1.43.1 to 1.46.1 #4585

Merged
merged 8 commits into from
Aug 28, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 23, 2024

Bumps @playwright/test from 1.43.1 to 1.46.1.

Release notes

Sourced from @​playwright/test's releases.

v1.44.1

Highlights

microsoft/playwright#30779 - [REGRESSION]: When using video: 'on' with VSCode extension the browser got closed microsoft/playwright#30755 - [REGRESSION]: Electron launch with spaces inside executablePath didn't work microsoft/playwright#30770 - [REGRESSION]: Mask elements outside of viewport when creating fullscreen screenshots didn't work microsoft/playwright#30858 - [REGRESSION]: ipv6 got shown instead of localhost in show-trace/show-report

Browser Versions

  • Chromium 125.0.6422.14
  • Mozilla Firefox 125.0.1
  • WebKit 17.4

This version was also tested against the following stable channels:

  • Google Chrome 124
  • Microsoft Edge 124

v1.44.0

New APIs

Accessibility assertions

  • expect(locator).toHaveAccessibleName() checks if the element has the specified accessible name:

    const locator = page.getByRole('button');
    await expect(locator).toHaveAccessibleName('Submit');
  • expect(locator).toHaveAccessibleDescription() checks if the element has the specified accessible description:

    const locator = page.getByRole('button');
    await expect(locator).toHaveAccessibleDescription('Upload a photo');
  • expect(locator).toHaveRole() checks if the element has the specified ARIA role:

    const locator = page.getByTestId('save-button');
    await expect(locator).toHaveRole('button');

Locator handler

  • After executing the handler added with page.addLocatorHandler(), Playwright will now wait until the overlay that triggered the handler is not visible anymore. You can opt-out of this behavior with the new noWaitAfter option.
  • You can use new times option in page.addLocatorHandler() to specify maximum number of times the handler should be run.
  • The handler in page.addLocatorHandler() now accepts the locator as argument.
  • New page.removeLocatorHandler() method for removing previously added locator handlers.

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels May 23, 2024
@dependabot dependabot bot requested a review from rafeerahman May 23, 2024 16:33
@rafeerahman
Copy link
Contributor

will try and get to this soon.

@rafeerahman
Copy link
Contributor

@pdehaan Wondering if you could help look into this. For some reason the tests idle on the firefox browser with this version when sent to the subscription page.

After running npx playwright install, this test is an example of the idle state,

E2E_TEST_ENV="prod" npx playwright test -g "Verify that the user can select what type of plan they want" --project="firefox" --headed

See https://github.com/mozilla/blurts-server/actions/runs/9229668146 screenshots as well.

Relay firefox tests also fail on this 1.44.0, https://github.com/mozilla/fx-private-relay/actions/runs/9229683742/job/25396368649

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/playwright/test-1.44.1 branch 6 times, most recently from c146195 to 6358844 Compare May 28, 2024 14:40
Bumps [@playwright/test](https://github.com/microsoft/playwright) from 1.43.1 to 1.44.1.
- [Release notes](https://github.com/microsoft/playwright/releases)
- [Commits](microsoft/playwright@v1.43.1...v1.44.1)

---
updated-dependencies:
- dependency-name: "@playwright/test"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/playwright/test-1.44.1 branch from 6358844 to 4111376 Compare May 28, 2024 14:45
Copy link

@flozia flozia force-pushed the dependabot/npm_and_yarn/playwright/test-1.44.1 branch from ab5bbdf to 5038451 Compare May 29, 2024 11:38
Comment on lines 47 to 49
# Get the current Playwright version listed in package.json
PLAYWRIGHT_VERSION=$(npm view @playwright/test version)
echo "Playwright Version: $PLAYWRIGHT_VERSION"
Copy link
Collaborator

@flozia flozia May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafeerahman @mansaj It seems like there was an issue with determining the current Playwright version in CI. We should be able to just directly get it with npm view @playwright/test version.

Copy link
Collaborator

@pdehaan pdehaan May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flozia I'm never sure when npm view queries the local package vs the remote registry. For example, this is what I see when running against main branch:

npm view @playwright/test version
# 1.44.1

npm ls @playwright/test
monitor@1.0.0 /Volumes/Dev/github/mozilla/blurts-server
├── @playwright/test@1.43.1
└─┬ next@14.2.3
  └── @playwright/test@1.43.1 deduped


npx playwright --version
# "Version 1.43.1"

Although, the playwright --version will return a string with the "Version " prefix, which might be ugly if we echo "Playwright Version: Version 1.44.1", so we might still need some sed magic:

npx playwright --version | sed 's/Version //'
# "1.43.1"

(since I'm very lazy and it's easier to remove the prefix than it is to try and match the semver string)

Copy link
Collaborator

@flozia flozia May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that’s right: npm view might be a potential mismatch because it checks the remote version. Otherwise, npm ls @playwright/test --depth=0 | grep @playwright/test | sed 's/.*@//' could work as well. I like your suggestion to use npx since it is easy to parse — updated in a8bdde6.

@flozia flozia requested a review from mansaj May 29, 2024 11:45
@flozia flozia force-pushed the dependabot/npm_and_yarn/playwright/test-1.44.1 branch from f0fbc91 to 5038451 Compare May 29, 2024 13:20
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 1, 2024

A newer version of @​playwright/test exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@rhelmer
Copy link
Collaborator

rhelmer commented Jul 31, 2024

@flozia any idea what's left on this one? Have we landed other @playwright/test updates in the meantime or are we stuck on this version?

@flozia flozia self-assigned this Aug 28, 2024
…ub.com:mozilla/blurts-server into dependabot/npm_and_yarn/playwright/test-1.44.1
@flozia flozia changed the title Bump @playwright/test from 1.43.1 to 1.44.1 Bump @playwright/test from 1.43.1 to 1.46.1 Aug 28, 2024
@flozia
Copy link
Collaborator

flozia commented Aug 28, 2024

@flozia any idea what's left on this one? Have we landed other @playwright/test updates in the meantime or are we stuck on this version?

@rhelmer We experienced test failures with 1.44.1 that we did not investigate further — upgrading to the latest version 1.46.1 with this PR now.

@flozia
Copy link
Collaborator

flozia commented Aug 28, 2024

@dependabot merge

@flozia flozia merged commit 645715f into main Aug 28, 2024
15 checks passed
@flozia flozia deleted the dependabot/npm_and_yarn/playwright/test-1.44.1 branch August 28, 2024 11:32
Copy link

Cleanup completed - database 'blurts-server-pr-4585' destroyed, cloud run service 'blurts-server-pr-4585' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants