-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump @playwright/test from 1.43.1 to 1.46.1 #4585
Conversation
will try and get to this soon. |
@pdehaan Wondering if you could help look into this. For some reason the tests idle on the firefox browser with this version when sent to the subscription page. After running
See https://github.com/mozilla/blurts-server/actions/runs/9229668146 screenshots as well. Relay firefox tests also fail on this 1.44.0, https://github.com/mozilla/fx-private-relay/actions/runs/9229683742/job/25396368649 |
c146195
to
6358844
Compare
Bumps [@playwright/test](https://github.com/microsoft/playwright) from 1.43.1 to 1.44.1. - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.43.1...v1.44.1) --- updated-dependencies: - dependency-name: "@playwright/test" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
6358844
to
4111376
Compare
Preview URL 🚀 : https://blurts-server-pr-4585-mgjlpikfea-uk.a.run.app |
ab5bbdf
to
5038451
Compare
.github/workflows/e2e_pr.yml
Outdated
# Get the current Playwright version listed in package.json | ||
PLAYWRIGHT_VERSION=$(npm view @playwright/test version) | ||
echo "Playwright Version: $PLAYWRIGHT_VERSION" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rafeerahman @mansaj It seems like there was an issue with determining the current Playwright version in CI. We should be able to just directly get it with npm view @playwright/test version
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flozia I'm never sure when npm view queries the local package vs the remote registry. For example, this is what I see when running against main branch:
npm view @playwright/test version
# 1.44.1
npm ls @playwright/test
monitor@1.0.0 /Volumes/Dev/github/mozilla/blurts-server
├── @playwright/test@1.43.1
└─┬ next@14.2.3
└── @playwright/test@1.43.1 deduped
npx playwright --version
# "Version 1.43.1"
Although, the playwright --version will return a string with the "Version " prefix, which might be ugly if we echo "Playwright Version: Version 1.44.1", so we might still need some sed magic:
npx playwright --version | sed 's/Version //'
# "1.43.1"
(since I'm very lazy and it's easier to remove the prefix than it is to try and match the semver string)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that’s right: npm view
might be a potential mismatch because it checks the remote version. Otherwise, npm ls @playwright/test --depth=0 | grep @playwright/test | sed 's/.*@//'
could work as well. I like your suggestion to use npx
since it is easy to parse — updated in a8bdde6.
f0fbc91
to
5038451
Compare
A newer version of @playwright/test exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
@flozia any idea what's left on this one? Have we landed other |
…ub.com:mozilla/blurts-server into dependabot/npm_and_yarn/playwright/test-1.44.1
@dependabot merge |
Cleanup completed - database 'blurts-server-pr-4585' destroyed, cloud run service 'blurts-server-pr-4585' destroyed |
Bumps @playwright/test from 1.43.1 to 1.46.1.
Release notes
Sourced from
@playwright/test
's releases.... (truncated)
Commits
afacb84
chore: mark v1.44.1 (#30942)be13365
cherry-pick(#30853): chore: print friendly localhost address from http server...67b85e6
docs: cherry-pick dotnet docs enhancements + release-notes (#30927)32bde52
cherry-pick(#30832): chore(testServer): accept video parameter when running t...5d26230
cherry-pick(#30807): chore: do not close the reused context when video is on3867d55
cherry-pick(#30820): fix(electron): allow launching with spaces in path (#30830)01bf93c
cherry-pick(#30800): Revert "fix(highlight): highlight Top Layer elements (#3...1b2de3f
cherry-pick(#30708): docs(python): roll fixes (#30709)a6aa50b
chore: set version to 1.44.0 (#30680)54c157d
cherry-pick(#30677): chore: print resolved host in the http server te… (#30679)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)