Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

for #541: run compare-locales validate on Travis #544

Merged
merged 2 commits into from
Oct 23, 2018
Merged

for #541: run compare-locales validate on Travis #544

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eea3408
for #541: run compare-locales validate on Travis
groovecoder Oct 22, 2018
72bb13d
also compare-locales everything in locales/
groovecoder Oct 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,12 @@ services:
- postgresql
env:
- NODE_ENV=tests
install:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, now we're getting the following error:

sh: 1: npm-run-all: not found

I wonder if this is causing $ npm install (or $ npm ci) to not get called, and maybe we should rename this to "before_install:", similar to https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#using-a-specific-npm-version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just updated install to do both pip and npm

- sudo pip install compare-locales
- npm install
before_script:
- compare-locales --validate l10n.toml .
- compare-locales l10n.toml . `ls locales`
- cp .env-dist .env
- createdb test-blurts
- npm install npm@latest -g