Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cython3 tests for now #874

Merged
merged 4 commits into from
Sep 4, 2023
Merged

Fix Cython3 tests for now #874

merged 4 commits into from
Sep 4, 2023

Conversation

jschwe
Copy link
Contributor

@jschwe jschwe commented Sep 3, 2023

See the individual commits. Summary:

  • Change filename of generated files during tests to prevent hard error from Cython
  • Change filenames of the expectations to match those of the generated files
  • Allowing warnings for Cython3 tests for now

The Cython3 deprecation warnings will become hard errors in future versions.

Closes #873

Since Cython 3.0 using dots appart from the extension is
a hard error. See issue: cython/cython#2686
Cython 3.0 deprecated `IF` and `DEF`. Until this is fixed
allow warnings in our `Cython` tests.
Background: cython/cython#4310

Note the warnings will become hard errors in the future.
Rename expectation files to contain only one dot.
This is needed for the Cython tests as of Cython 3.
The following script was used in a clean repository
to rename the files:

```sh
 ls | sed -E -n 's/(.*)\.(both|tag)?((\..*)?\.(c|cpp|pyx))/mv "\1.\2\3" "\1_\2\3"/p' | sh
```
Copy link
Collaborator

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, that's rather unfortunate breakage, thanks for doing this.

@emilio emilio merged commit e7613e5 into mozilla:master Sep 4, 2023
2 checks passed
@jschwe jschwe deleted the cython3 branch September 4, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail with Cython 3.0.2
2 participants