Fix Cython3 tests for now #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Cython 3.0 using dots appart from the extension is a hard error. See issue: cython/cython#2686
Cython 3.0 deprecated `IF` and `DEF`. Until this is fixed allow warnings in our `Cython` tests. Background: cython/cython#4310 Note the warnings will become hard errors in the future.
Rename expectation files to contain only one dot. This is needed for the Cython tests as of Cython 3. The following script was used in a clean repository to rename the files: ```sh ls | sed -E -n 's/(.*)\.(both|tag)?((\..*)?\.(c|cpp|pyx))/mv "\1.\2\3" "\1_\2\3"/p' | sh ```
emilio
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commits. Summary:
The Cython3 deprecation warnings will become hard errors in future versions.
Closes #873