Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cython3 tests for now #874

Merged
merged 4 commits into from
Sep 4, 2023
Merged

Fix Cython3 tests for now #874

merged 4 commits into from
Sep 4, 2023

Commits on Sep 3, 2023

  1. Fix most Python tests with Cython 3.0 

    Since Cython 3.0 using dots appart from the extension is
a hard error. See issue: cython/cython#2686
    @jschwe
    jschwe committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    e51b241 View commit details
    Browse the repository at this point in the history

  2. Allow Warnings in Cython tests 

    Cython 3.0 deprecated `IF` and `DEF`. Until this is fixed
allow warnings in our `Cython` tests.
Background: cython/cython#4310

Note the warnings will become hard errors in the future.
    @jschwe
    jschwe committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    0d56d8a View commit details
    Browse the repository at this point in the history

  3. Rename expectations files 

    Rename expectation files to contain only one dot.
This is needed for the Cython tests as of Cython 3.
The following script was used in a clean repository
to rename the files:

```sh
 ls | sed -E -n 's/(.*)\.(both|tag)?((\..*)?\.(c|cpp|pyx))/mv "\1.\2\3" "\1_\2\3"/p' | sh
```
    @jschwe
    jschwe committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    4a1e0f7 View commit details
    Browse the repository at this point in the history

  4. CI: Use Cython 3.0

    @jschwe
    jschwe committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    19b7842 View commit details
    Browse the repository at this point in the history