Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sentry to 0.12.1 to fix memory leak #66

Closed
wants to merge 2 commits into from

Conversation

mythmon
Copy link
Contributor

@mythmon mythmon commented Sep 16, 2019

sentry-rust had an issue that was fixed in version 0.12.1 that caused it to leak memory a lot. Updating the package fixes this.

Copy link

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome good find! 🎉

@jaredlockhart
Copy link

bors r+

bors bot added a commit that referenced this pull request Sep 16, 2019
66: Update sentry to 0.12.1 to fix memory leak r=jaredkerim a=mythmon

`sentry-rust` had [an issue](getsentry/sentry-rust#108) that was fixed in version 0.12.1 that caused it to leak memory a lot. Updating the package fixes this.

Co-authored-by: Mike Cooper <mythmon@gmail.com>
@mythmon
Copy link
Contributor Author

mythmon commented Sep 16, 2019

This isn't going to be able to merge util we fix the problem with the memoffset crate that is causing CI to fail.

@mythmon
Copy link
Contributor Author

mythmon commented Sep 20, 2019

We #64, we removed Sentry (since it isn't current compatible with actix-web 1.0). This change is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants