Add pytest-responses. Fixes #34

backend/requirements-dev.txt

@@ -1,4 +1,5 @@
 fakeredis==1.0.5
 pre-commit==1.18.3
 pytest==5.1.2
+pytest-responses==0.4.0
 responses==0.10.6

bot/requirements-dev.txt

@@ -2,4 +2,5 @@ jsonschema==3.0.2
 json-e==3.0.0
 pre-commit==1.18.3
 pytest==5.1.2
+pytest-responses==0.4.0
 responses==0.10.6

bot/tests/test_artifacts.py

@@ -259,7 +259,6 @@ def build_task(task_state):
         }
 
 
-@responses.activate
 def test_download_all(
     LINUX_TASK_ID, LINUX_TASK, GROUP_TASKS_1, GROUP_TASKS_2, fake_artifacts
 ):

bot/tests/test_chunk_mapping.py

@@ -61,7 +61,6 @@ def assert_chunk_to_test(c, platform, chunk, tests):
     assert set([e[0] for e in results]) == set(tests)
 
 
-@responses.activate
 def test_zero_coverage(tmpdir, fake_artifacts_handler, fake_hg_repo_with_contents):
     tmp_path = tmpdir.strpath
 

bot/tests/test_notifier.py

@@ -1,6 +1,4 @@
 # -*- coding: utf-8 -*-
-import responses
-
 from code_coverage_bot.notifier import notify_email
 from code_coverage_bot.phabricator import PhabricatorUploader
 from conftest import add_file
@@ -10,7 +8,6 @@
 from conftest import covdir_report
 
 
-@responses.activate
 def test_notification(mock_secrets, mock_taskcluster, mock_phabricator, fake_hg_repo):
     hg, local, remote = fake_hg_repo
 

bot/tests/test_phabricator.py

@@ -14,7 +14,6 @@
 from conftest import covdir_report
 
 
-@responses.activate
 def test_simple(mock_secrets, mock_phabricator, fake_hg_repo):
     hg, local, remote = fake_hg_repo
 
@@ -85,7 +84,6 @@ def test_simple(mock_secrets, mock_phabricator, fake_hg_repo):
     assert params["lint"] == []
 
 
-@responses.activate
 def test_file_with_no_coverage(mock_secrets, fake_hg_repo):
     hg, local, remote = fake_hg_repo
 
@@ -103,7 +101,6 @@ def test_file_with_no_coverage(mock_secrets, fake_hg_repo):
     assert results == {1: {}}
 
 
-@responses.activate
 def test_one_commit_without_differential(mock_secrets, fake_hg_repo):
     hg, local, remote = fake_hg_repo
 
@@ -127,7 +124,6 @@ def test_one_commit_without_differential(mock_secrets, fake_hg_repo):
     assert results == {}
 
 
-@responses.activate
 def test_two_commits_two_files(mock_secrets, fake_hg_repo):
     hg, local, remote = fake_hg_repo
 
@@ -169,7 +165,6 @@ def test_two_commits_two_files(mock_secrets, fake_hg_repo):
     }
 
 
-@responses.activate
 def test_changesets_overwriting(mock_secrets, fake_hg_repo):
     hg, local, remote = fake_hg_repo
 
@@ -195,7 +190,6 @@ def test_changesets_overwriting(mock_secrets, fake_hg_repo):
     }
 
 
-@responses.activate
 def test_changesets_displacing(mock_secrets, fake_hg_repo):
     hg, local, remote = fake_hg_repo
 
@@ -225,7 +219,6 @@ def test_changesets_displacing(mock_secrets, fake_hg_repo):
     }
 
 
-@responses.activate
 def test_changesets_reducing_size(mock_secrets, fake_hg_repo):
     hg, local, remote = fake_hg_repo
 
@@ -251,7 +244,6 @@ def test_changesets_reducing_size(mock_secrets, fake_hg_repo):
     }
 
 
-@responses.activate
 def test_changesets_overwriting_one_commit_without_differential(
     mock_secrets, fake_hg_repo
 ):
@@ -279,7 +271,6 @@ def test_changesets_overwriting_one_commit_without_differential(
     }
 
 
-@responses.activate
 def test_removed_file(mock_secrets, fake_hg_repo):
     hg, local, remote = fake_hg_repo
 
@@ -300,7 +291,6 @@ def test_removed_file(mock_secrets, fake_hg_repo):
     assert results == {1: {}}
 
 
-@responses.activate
 def test_backout_removed_file(mock_secrets, fake_hg_repo):
     hg, local, remote = fake_hg_repo
 

bot/tests/test_taskcluster.py

@@ -13,7 +13,6 @@
 from conftest import FIXTURES_DIR
 
 
-@responses.activate
 def test_get_task_status(LINUX_TASK_ID, LINUX_TASK_STATUS):
     responses.add(
         responses.GET,
@@ -24,7 +23,6 @@ def test_get_task_status(LINUX_TASK_ID, LINUX_TASK_STATUS):
     assert taskcluster.get_task_status(LINUX_TASK_ID) == LINUX_TASK_STATUS
 
 
-@responses.activate
 def test_get_task_details(LINUX_TASK_ID, LINUX_TASK):
     responses.add(
         responses.GET,
@@ -35,7 +33,6 @@ def test_get_task_details(LINUX_TASK_ID, LINUX_TASK):
     assert taskcluster.get_task_details(LINUX_TASK_ID) == LINUX_TASK
 
 
-@responses.activate
 def test_get_task(LINUX_TASK_ID, LATEST_LINUX, WIN_TASK_ID, LATEST_WIN):
     responses.add(
         responses.GET,
@@ -64,7 +61,6 @@ def test_get_task(LINUX_TASK_ID, LATEST_LINUX, WIN_TASK_ID, LATEST_WIN):
     )
 
 
-@responses.activate
 def test_get_task_not_found(TASK_NOT_FOUND):
     responses.add(
         responses.GET,
@@ -81,7 +77,6 @@ def test_get_task_not_found(TASK_NOT_FOUND):
     )
 
 
-@responses.activate
 def test_get_task_failure(TASK_NOT_FOUND):
     err = TASK_NOT_FOUND.copy()
     err["code"] = "RandomError"
@@ -100,7 +95,6 @@ def test_get_task_failure(TASK_NOT_FOUND):
         )
 
 
-@responses.activate
 def test_get_task_artifacts(LINUX_TASK_ID, LINUX_TASK_ARTIFACTS):
     responses.add(
         responses.GET,
@@ -114,7 +108,6 @@ def test_get_task_artifacts(LINUX_TASK_ID, LINUX_TASK_ARTIFACTS):
     )
 
 
-@responses.activate
 def test_get_tasks_in_group(GROUP_TASKS_1, GROUP_TASKS_2):
     responses.add(
         responses.GET,
@@ -263,7 +256,6 @@ def test_get_platform(task_name, expected):
 
 
 @mock.patch("time.sleep")
-@responses.activate
 def test_download_artifact_forbidden(mocked_sleep, tmpdir):
     responses.add(
         responses.GET,
@@ -286,7 +278,6 @@ def test_download_artifact_forbidden(mocked_sleep, tmpdir):
 
 
 @mock.patch("time.sleep")
-@responses.activate
 def test_download_artifact_badzip(mocked_sleep, tmpdir):
     responses.add(
         responses.GET,

events/requirements-dev.txt

@@ -1,3 +1,4 @@
 pytest
 pytest-asyncio
+pytest-responses==0.4.0
 responses

events/tests/test_workflow.py

@@ -71,15 +71,13 @@ async def _check():
     return loop.run_until_complete(_check())
 
 
-@responses.activate
 def test_wrong_branch(mock_taskcluster):
     bus = MessageBus()
     hook = CodeCoverage("services-staging-codecoverage/bot", "project-test", bus)
 
     assert run_async_parser(hook, "bNq-VIT-Q12o6nXcaUmYNQ") is None
 
 
-@responses.activate
 def test_success(mock_taskcluster):
     bus = MessageBus()
     hook = CodeCoverage("services-staging-codecoverage/bot", "project-test", bus)
@@ -92,7 +90,6 @@ def test_success(mock_taskcluster):
     ]
 
 
-@responses.activate
 def test_success_windows(mock_taskcluster):
     bus = MessageBus()
     hook = CodeCoverage("services-staging-codecoverage/bot", "project-test", bus)
@@ -105,7 +102,6 @@ def test_success_windows(mock_taskcluster):
     ]
 
 
-@responses.activate
 def test_success_try(mock_taskcluster):
     bus = MessageBus()
     hook = CodeCoverage("services-staging-codecoverage/bot", "project-test", bus)