-
Notifications
You must be signed in to change notification settings - Fork 92
restrict on push builds to master and production in taskcluster #2408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhearsum
added a commit
to bhearsum/fxci-config
that referenced
this pull request
Jul 30, 2024
This depends on a handful of PRs to these repos: mozilla-mobile/reference-browser#2982 mozilla-mobile/firefox-ios#21357 mozilla/code-review#2289 mozilla/code-coverage#2408 mozilla/translations#777 After this change, the only Github repositories with `*` branches will be `staging` repositories, as was discussed in mozilla-releng#18.
bhearsum
added a commit
to bhearsum/fxci-config
that referenced
this pull request
Jul 30, 2024
This depends on a handful of PRs to these repos: mozilla-mobile/reference-browser#2982 mozilla-mobile/firefox-ios#21357 mozilla/code-review#2289 mozilla/code-coverage#2408 mozilla/translations#777 After this change, the only Github repositories with `*` branches will be `staging` repositories, as was discussed in mozilla-releng#18.
bhearsum
added a commit
to bhearsum/fxci-config
that referenced
this pull request
Aug 1, 2024
This also adds branches to a couple of repositories where I noticed we were missing one that the build on. This depends on a handful of PRs to these repos: mozilla-mobile/reference-browser#2982 mozilla-mobile/firefox-ios#21357 mozilla/code-review#2289 mozilla/code-coverage#2408 mozilla/translations#777 After this change, the only Github repositories with `*` branches will be `staging` repositories, as was discussed in mozilla-releng#18.
@bhearsum we also have a "testing" branch that we'd need to add to the list. |
bhearsum
added a commit
to bhearsum/fxci-config
that referenced
this pull request
Aug 2, 2024
This also adds branches to a couple of repositories where I noticed we were missing one that the build on. This depends on a handful of PRs to these repos: mozilla-mobile/reference-browser#2982 mozilla-mobile/firefox-ios#21357 mozilla/code-review#2289 mozilla/code-coverage#2408 mozilla/translations#777 After this change, the only Github repositories with `*` branches will be `staging` repositories, as was discussed in mozilla-releng#18.
In https://bugzilla.mozilla.org/show_bug.cgi?id=1907217 we're making scopes more explicit for branches. Because of this, pushes to branches not named in that repository will not be able to run. If this will be problematic, or we need to add more branches to this list, please let me know and we'll sort it out!
@marco-c - can we get this merged if it looks good now? |
marco-c
approved these changes
Aug 7, 2024
bhearsum
added a commit
to bhearsum/fxci-config
that referenced
this pull request
Aug 13, 2024
This also adds branches to a couple of repositories where I noticed we were missing one that the build on. This depends on a handful of PRs to these repos: mozilla-mobile/reference-browser#2982 mozilla-mobile/firefox-ios#21357 mozilla/code-review#2289 mozilla/code-coverage#2408 mozilla/translations#777 After this change, the only Github repositories with `*` branches will be `staging` repositories, as was discussed in mozilla-releng#18.
bhearsum
added a commit
to bhearsum/fxci-config
that referenced
this pull request
Aug 14, 2024
This also adds branches to a couple of repositories where I noticed we were missing one that the build on. This depends on a handful of PRs to these repos: mozilla-mobile/reference-browser#2982 mozilla-mobile/firefox-ios#21357 mozilla/code-review#2289 mozilla/code-coverage#2408 mozilla/translations#777 After this change, the only Github repositories with `*` branches will be `staging` repositories, as was discussed in mozilla-releng#18.
bhearsum
added a commit
to mozilla-releng/fxci-config
that referenced
this pull request
Aug 14, 2024
#46) This also adds branches to a couple of repositories where I noticed we were missing one that the build on. This depends on a handful of PRs to these repos: mozilla-mobile/reference-browser#2982 mozilla-mobile/firefox-ios#21357 mozilla/code-review#2289 mozilla/code-coverage#2408 mozilla/translations#777 After this change, the only Github repositories with `*` branches will be `staging` repositories, as was discussed in #18.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://bugzilla.mozilla.org/show_bug.cgi?id=1907217 we're making scopes more explicit for branches. Because of this, pushes to branches not named in that repository will not be able to run. If this will be problematic, or we need to add more branches to this list, please let me know and we'll sort it out!