Workaround to get parsepatch to run on alpine #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-c
reviewed
Jan 7, 2020
| @@ -36,7 +36,7 @@ def load_hgmo_patch(diff): | |||
| resp = requests.get(url) | |||
| resp.raise_for_status() | |||
|
|
|||
| patch = Patch.parse_patch(resp.content, skip_comments=False) | |||
| patch = Patch.parse_patch(resp.content.decode("utf-8"), skip_comments=False) | |||
There was a problem hiding this comment.
Might be better to ignore possible decoding errors
There was a problem hiding this comment.
Yep, that works too, it should be equivalent to resp.content.decode("utf-8", "replace").
There was a problem hiding this comment.
i tested in alpine, that works nicely, thanks @jcristau !
marco-c
approved these changes
Jan 7, 2020
marco-c
reviewed
Jan 7, 2020
| @@ -36,7 +36,7 @@ def load_hgmo_patch(diff): | |||
| resp = requests.get(url) | |||
| resp.raise_for_status() | |||
|
|
|||
| patch = Patch.parse_patch(resp.content, skip_comments=False) | |||
| patch = Patch.parse_patch(resp.content.decode("utf-8"), skip_comments=False) | |||
There was a problem hiding this comment.
Suggested change
| patch = Patch.parse_patch(resp.content.decode("utf-8"), skip_comments=False) | |
| patch = Patch.parse_patch(resp.content.decode("utf-8", "ignore"), skip_comments=False) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #398
Reported upstream on mozilla/parsepatch#11