Process diffs only once in load_in_patch#398
Merged
La0 merged 3 commits intomozilla:masterfrom Jan 7, 2020
Merged
Conversation
Collaborator
That's strange, could you file an issue on https://github.com/mozilla/pyo3-parsepatch/issues, with the example case where it is failing. |
Collaborator
Author
marco-c
reviewed
Jan 7, 2020
Collaborator
|
Could you split the PR in two, since they are two separate bug fixes not depending on each other? |
…_patch.py Co-Authored-By: Marco Castelluccio <mcastelluccio@mozilla.com>
Collaborator
Author
|
Ok, this one only has the |
marco-c
approved these changes
Jan 7, 2020
Collaborator
marco-c
left a comment
marco-c
left a comment
There was a problem hiding this comment.
LGTM, please fix the PR name / commit message when landing
La0
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found 2 bugs when running on Heroku testing:
DISTINCT