Skip to content
This repository was archived by the owner on Feb 15, 2020. It is now read-only.

Conversation

jezdez
Copy link
Contributor

@jezdez jezdez commented Feb 10, 2017

If Spark is writing to the file using the "spark" user as indicated in the output Sam posted in bug 1335228 then we should chown the logfile.

@jezdez jezdez requested a review from vitillo February 10, 2017 09:12
Copy link
Contributor

@vitillo vitillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Has this been manually tested?

@jezdez
Copy link
Contributor Author

jezdez commented Feb 10, 2017

@vitillo Can you elaborate what manually testing means in that case?

@vitillo
Copy link
Contributor

vitillo commented Feb 10, 2017

As this project doesn't have any automated test suite, I would like to know how you verified (supposedly "manually") that the issue mentioned by Sam has been fixed.

@jezdez
Copy link
Contributor Author

jezdez commented Feb 10, 2017

@vitillo Right, I haven't run the script, do you mean by running the ansible playbook?

@vitillo
Copy link
Contributor

vitillo commented Feb 10, 2017

Unfortunately we don't have different environments yet so you can't just run the ansible playbook to test a change in the bootstrap script.

One way to do it would be to create a vanilla EMR cluster (i.e. not from within ATMO), run the bootstrap script manually and finally launch a Spark job and verify that the error Sam mentioned is gone.

An even better way would be to fix Bug 1312747 before so that testing these kind of changes will become much easier.

@jezdez
Copy link
Contributor Author

jezdez commented Feb 10, 2017

@vitillo Okay, that's some viable yak you just offered to be shaved. I accept :)

@vitillo
Copy link
Contributor

vitillo commented Feb 10, 2017

\o/

@acmiyaguchi acmiyaguchi self-requested a review August 24, 2017 22:20
@acmiyaguchi
Copy link
Contributor

@jezdez Bumping this PR since all the requisites are in order. Changing the owner of the spark log does not fix the original bug. One of the reasons for this might be because spark is writing its event log to hdfs. It would still be nice to obtain a copy of the spark application logs outside of the yarn application logs.

Copy link
Contributor

@acmiyaguchi acmiyaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't fix the problem described in the bug.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants