Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email templates l10n] Variables not replaced with the correct text in subscriptionDowngrade and subscriptionUpgrade templates (HTML and plaintext) - German #11785

Closed
data-sync-user opened this issue Jan 28, 2022 · 3 comments · Fixed by mozilla/fxa-content-server-l10n#549
Assignees
Labels
severity:normal Label for QA to mark normal issues logged status:verified

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Jan 28, 2022

Build:

Stage (Train 224.2)

Affected platforms:

Windows 10 64-bit

Browsers tested on:

Firefox, latest release

Prerequisites:
The user has already an active subscription.

Steps to reproduce:

  1. The user downgrades his subscription. (Stripe dashboard)

Actual result:
Variables are not replaced with the correct text.

Expected result:

Variables are replaced with the correct text.

Notes:
Same issue occurs for subscriptionUpgrade template.

┆Issue is synchronized with this Jira Bug
┆Attachments: dollar sign 2.PNG | dollar sign displayed after word.PNG | downgrade - new situation.PNG | downgrade - new situation (6de735c4-fb07-4e7a-8336-c0f26e163a91).PNG | Ge - subscrDowngrade - variable not replaced (HTML&plain).PNG | upgrade - new situation.PNG

@data-sync-user
Copy link
Collaborator Author

➤ Bianca Oltean commented:

I verified this on Stage [Train 225.2] under Windows 10 64-bit. I confirm that the variables are replaced with the correct data for both templates. New situation:

!downgrade - new situation.PNG|width=533,height=389!

But there is another minor issue present. See screenshots below: CC Lisa Chan

!dollar sign 2.PNG|width=480,height=397!

!dollar sign displayed after word.PNG|width=497,height=425!

@data-sync-user
Copy link
Collaborator Author

➤ Lisa Chan commented:

Bianca Oltean Thanks, I have submitted a fix ( mozilla/fxa-content-server-l10n#551 ) for this!

@data-sync-user
Copy link
Collaborator Author

➤ Bianca Oltean commented:

This dollar sign issue (see comment below for more details) is verified as fixed on Stage [Train 226] under Windows 10. No dollar sign is displayed at the end of sentence.

!upgrade - new situation.PNG|width=502,height=382!

!downgrade - new situation (6de735c4-fb07-4e7a-8336-c0f26e163a91).PNG|width=515,height=390!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:normal Label for QA to mark normal issues logged status:verified
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants