Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

latest test failure: delete_account, sign in, cancel delete account #3101

Closed
shane-tomlinson opened this issue Oct 23, 2019 · 2 comments · Fixed by #3104 or #3117
Closed

latest test failure: delete_account, sign in, cancel delete account #3101

shane-tomlinson opened this issue Oct 23, 2019 · 2 comments · Fixed by #3104 or #3117
Assignees
@shane-tomlinson
Milestone
Train 149: FxA

Comments

@shane-tomlinson
Copy link
Contributor

shane-tomlinson commented Oct 23, 2019 •
edited
Loading

Seen here: https://tc-test.dev.lcip.org/viewLog.html?buildId=60023&tab=buildResultsDiv&buildTypeId=FxaLatest_FunctionalTests as well as locally

STR

  1. npm run test-latest -- --grep="delete_account - sign in, cancel delete account"

× firefox on mac 18.7.0 - delete_account - sign in, cancel delete account (4.706s)
StaleElementReference: [POST http://localhost:4444/wd/hub/session/c581c54b-a542-724a-ab0e-c3ebd2ea632e/element/a8f2e8a2-2d2c-034d-8d6c-7b0b7643c60a/click / {}] The element reference of is stale; either the element is no longer attached to the DOM, it is not in the current frame context, or the document has been refreshed
For documentation on this error, please visit: https://www.seleniumhq.org/exceptions/stale_element_reference.html
Build info: version: '3.141.59', revision: 'e82be7d358', time: '2018-11-14T08:25:53'
System info: host: 'stomlinson-30887', ip: '192.168.1.229', os.name: 'Mac OS X', os.arch: 'x86_64', os.version: '10.14.6', java.version: '9.0.1'
Driver info: driver.version: unknown
at Test.sign in, cancel delete account [as test] @ tests/functional/delete_account.js:73:12
@ src/lib/Test.ts:263:51

blocks #2877
shane-tomlinson added a commit that referenced this issue Oct 23, 2019
@shane-tomlinson
fix(test): Do not run mocha tests on teamcity.
ee756f1 
Teamcity cannot run mocha tests against latest, stage, stable, etc
because only dev instances expose the /tests/index.html endpoint.

Only run the mocha tests as part of the functional
suite if the SKIP_MOCHA environment variable is not set

Teamcity has this environment variable set and
will stop running the mocha tests during its
test runs.

fixes #3101
@shane-tomlinson shane-tomlinson mentioned this issue Oct 23, 2019
Merged
@shane-tomlinson shane-tomlinson added this to the Train 149: FxA milestone Oct 23, 2019
@shane-tomlinson
Copy link
Contributor Author

Woops, #3104 did not fix this, re-opening.

@shane-tomlinson
Copy link
Contributor Author

Here's a different error from https://tc-test.dev.lcip.org/viewLog.html?buildId=60099&tab=buildResultsDiv&buildTypeId=FxaLatest_FunctionalTests:

Error: [POST http://localhost:4444/wd/hub/session/a1a9c5cd-aa38-4f09-bb62-8fb41a5b7b98/element/584c0cec-8ffa-488f-ba81-c79dd1023977/click / {}] Element could not be scrolled into view
Build info: version: '3.141.59', revision: 'e82be7d358', time: '2018-11-14T08:25:53'
System info: host: '4ccfe51f7550', ip: '172.17.0.3', os.name: 'Linux', os.arch: 'amd64', os.version: '4.4.41-36.55.amzn1.x86_64', java.version: '1.8.0_144'
Driver info: driver.version: unknown
at Test.sign in, cancel delete account [as test] @ tests/functional/delete_account.js:73:12
@ src/lib/Test.ts:263:51

shane-tomlinson added a commit that referenced this issue Oct 24, 2019
@shane-tomlinson
fix(test): Fix the broken delete_account test
f95c067 
After clicking the "cancel" button we were checking for the existence
of the '#settings' element, which could have gone stale due to a re-render.

Instead, ensure the delete panel details become hidden.

fixes #3101
@shane-tomlinson shane-tomlinson mentioned this issue Oct 24, 2019
Merged
@shane-tomlinson shane-tomlinson self-assigned this Oct 24, 2019
shane-tomlinson added a commit that referenced this issue Oct 25, 2019
@shane-tomlinson
fix(test): skip mocha tests in npm run test-latest
c636775 
In #3104 support was added for the SKIP_MOCHA enviroment
variable, if set, the mocha tests are skipped. SKIP_MOCHA
is set on teamcity, but wasn't locally when running
`npm run test-latest`, which allowed the mocha tests
to run, and fail.

issue #3101
issue #3104
@shane-tomlinson shane-tomlinson mentioned this issue Oct 25, 2019
Merged
meandavejustice pushed a commit to meandavejustice/fxa that referenced this issue Oct 28, 2019
@shane-tomlinson
fix(test): skip mocha tests in npm run test-latest
1d21e9f 
In mozilla#3104 support was added for the SKIP_MOCHA enviroment
variable, if set, the mocha tests are skipped. SKIP_MOCHA
is set on teamcity, but wasn't locally when running
`npm run test-latest`, which allowed the mocha tests
to run, and fail.

issue mozilla#3101
issue mozilla#3104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shane-tomlinson shane-tomlinson

Labels
None yet
Projects
None yet
Milestone
Train 149: FxA
1 participant
@shane-tomlinson