Mozillians API v2 #1152
Mozillians API v2 #1152
Conversation
johngian
force-pushed
the
api-users-skills-groups
branch
2 times, most recently
from
e94af61
to
966c257
Compare
|
Most of the work here is integrating @glogiotatidis work from [1] and [2]. @comzeradd [1] https://github.com/glogiotatidis/mozillians/tree/newapi-usersonly |
| """ | ||
| Returns a list of Mozillians groups respecting authorization | ||
| levels and privacy settings. | ||
| """ |
There was a problem hiding this comment.
Since the description is generated through the docstring, maybe you should consider adding a different docstring for GroupViewSet and UserProfileViewSet.
|
Is there a reason why commit e3ec255 is on its own? Docstrings should be part of the commit with the class. Moreover in the commit message you are adding docstrings for users/groups/skills but there only the docstrings for users/groups. |
johngian
force-pushed
the
api-users-skills-groups
branch
from
966c257
to
a7bcc2f
Compare
| <a class="brand" rel="nofollow" href="{% url 'api-root' %}"> | ||
| Mozillians API <span class="version">2</span> | ||
| </a> | ||
| {% endblock %} |
There was a problem hiding this comment.
Could you fix the indentation? You should indent after the block statements.
johngian
force-pushed
the
api-users-skills-groups
branch
5 times, most recently
from
ebf9add
to
879876d
Compare
Fixes bugs: 926673, 1011220, 1011227, 1011243 * Expose new API endpoint for v2 * Use django-rest-framework instead of tastypie * Respect per field privacy level * API Resources: Users, Groups, Skills * Manage API v2 in /admin * Add page to allow users manage their API keys * Grant PUBLIC level API access for vouched Mozillians
johngian
force-pushed
the
api-users-skills-groups
branch
from
879876d
to
454d141
Compare
No description provided.