No looping callback in getExtensionList() with Gecko 1.9.x. Fixes #88. #89

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Collaborator

xabolcs commented Jun 19, 2012

Easy fix, big win!

Contributor

whimboo commented Jun 19, 2012

Looks fine to me. At the same time I would like to see that we make use of your new ExtensionManager class over on pull #85.

whimboo closed this Jun 19, 2012

Collaborator

xabolcs commented Jun 19, 2012

whimboo commented

At the same time I would like to see that we make use of your new ExtensionManager class over on pull #85.

Are You talking about modularizing or just copying the idea?
I happily file another issue to move ExtensionManager out of aboutNightly.js into a *.jsm, with the few necessary methods implemented.
Even we could implement an nttAddonManager.jsm which simply imports AddonManager.jsm if exists or uses
an AddonManagerImpl() / ExtensionManagerImpl() inside and exports that as AddonManager.
Hm?
With that module we could do easily:

    Cu.import("resource://nightly/modules/nttAddonManager.jsm");
    AddonManager.someFunction(aParam, aCallback);

Thoughts?

Contributor

whimboo commented Jun 19, 2012

Sounds great. Lets do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment