Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No looping callback in getExtensionList() with Gecko 1.9.x. Fixes #88. #89

Conversation

xabolcs
Copy link
Collaborator

@xabolcs xabolcs commented Jun 19, 2012

Easy fix, big win!

@whimboo
Copy link
Contributor

whimboo commented Jun 19, 2012

Looks fine to me. At the same time I would like to see that we make use of your new ExtensionManager class over on pull #85.

whimboo pushed a commit to whimboo/nightlytt that referenced this pull request Jun 19, 2012
@whimboo whimboo closed this Jun 19, 2012
@xabolcs
Copy link
Collaborator Author

xabolcs commented Jun 19, 2012

whimboo commented

At the same time I would like to see that we make use of your new ExtensionManager class over on pull #85.

Are You talking about modularizing or just copying the idea?
I happily file another issue to move ExtensionManager out of aboutNightly.js into a *.jsm, with the few necessary methods implemented.
Even we could implement an nttAddonManager.jsm which simply imports AddonManager.jsm if exists or uses
an AddonManagerImpl() / ExtensionManagerImpl() inside and exports that as AddonManager.
Hm?
With that module we could do easily:

    Cu.import("resource://nightly/modules/nttAddonManager.jsm");
    AddonManager.someFunction(aParam, aCallback);

Thoughts?

@whimboo
Copy link
Contributor

whimboo commented Jun 19, 2012

Sounds great. Lets do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants