Update 'Contributors' section automatically in about:nightly. Fixes #58. #85

xabolcs · 2012-06-12T03:45:35Z

Hi!

This pull request contains:

fix for automatically filling Contributors
little styling fix for Songbird (it lacks of chrome://global/skin/about.css)
some fix for Nightly Tester Tools links

--HG-- rename : extension/chrome/content/aboutNightly.xhtml => extension/chrome/content/aboutNightly/aboutNightly.xhtml

…ing those from the install.rdf

whimboo · 2012-06-14T10:43:11Z

extension/chrome/content/aboutNightly/aboutNightly.js

+ * The Initial Developer of the Original Code is
+ *     Dave Townsend <dtownsend@oxymoronical.com>.
+ *
+ * Portions created by the Initial Developer are Copyright (C) 2007


This credit goes to you. Also please update the year. I hope that we can have a patch for the MPL2 license soon. Would you be interested in doing that?

whimboo commented on commit

I hope that we can have a patch for the MPL2 license soon. Would you be interested in doing that?

Sure!
I'd like to provide a file list with three element in the MPL2 issue (#39) before creating the commit:

files with new boilerplate

files with changed boilerplate

files with no boilerplate

Of course all files would came from extension directory.

- noting myself as initial developer, year - adding others from cvs and hg blame (the EM stuff, appendToList) - destructuring assignment to set Ci, Cu, ... - uppercasing ADDONID - no more has_EM - real callback of fillContributorsCallback - move extensionLoader() to ExtensionManager.getAddonByID() - ... and it now fills just names, no url for creator - new line at end of file - removing event listener - team changes in install.rdf

whimboo · 2012-06-18T13:59:20Z

Otherwise I like that change. Looks good and we can land it soon.

- ADDON_ID - haveAM

whimboo · 2012-06-19T06:58:39Z

extension/chrome/content/aboutNightly/aboutNightly.js

+  if (haveAM) {
+    AddonManager.getAddonByID(ADDON_ID, fillContributorsCallback);
+  } else {
+    ExtensionManager.getAddonByID(ADDON_ID, fillContributorsCallback);


There is no need for an if/else condition. Please directly put the code in the above try/catch block.

whimboo commented on commit

There is no need for an if/else condition. Please directly put the code in the above try/catch block.

I desagree about that.
haveAM is almost as safe as have_EM was.
But the recommended try ... catch method is more unsafe. It could hide underlying problems. (At least more than haveAM could.)

With this method you will not get any other information why the Cu.import() could have been failed. So the code I'm talking about here should be:

'+ try {

Cu.import("resource://gre/modules/AddonManager.jsm");

AddonManager.getAddonByID(ADDON_ID, fillContributorsCallback);

} catch(e) {

ExtensionManager.getAddonByID(ADDON_ID, fillContributorsCallback);

}`

xabolcs · 2012-06-19T07:59:22Z

whimboo commented on commit

With this method you will not get any other information why the Cu.import() could have been failed. ...

Yeah, because of that have I used have_EM.
I know what kind of code are You talking about. IMHO it's not the best pattern/practice.
As I said your try ... catch code is more unsafe like haveAM.
Because with Your method You will not get any other informarion why the Cu.import() or even AddonManager.getAddonByID() could have been failed.

Therefore I proposed the have_EM method: simply in check, without any exception to catch.

whimboo · 2012-06-19T09:12:59Z

Ah i see. Sure we can fix that by using:

var manager = null;
try:
  var { AddonManager: manager } = Cu.import("resource://gre/modules/AddonManager.jsm");
catch (e) {
  var manager = ExtensionManager;
}

if (manager) {
  ...
} else {
  throw whatever we want to report.
}

xabolcs · 2012-06-19T09:18:54Z

whimboo commented on commit

Ah i see. Sure we can fix that by using ...

Thanks, this is more acceptable for me. :)

xabolcs · 2012-06-19T22:07:10Z

Added commit d991c7f containing:

EM / AM changed to manager as recommended
no changes to comparisons - see my comment above!

whimboo · 2012-07-02T13:16:51Z

extension/chrome/content/aboutNightly/aboutNightly.js

+
+  var manager = null;
+  try {
+    var { AddonManager: manager } = Cu.import("resource://gre/modules/AddonManager.jsm");


That would redeclare manager which already exists since line 50. We should simply remove the var here. I would assume that will work.

whimboo · 2012-07-02T13:18:47Z

extension/chrome/content/aboutNightly/aboutNightly.js

+  } else {
+    throw Components.Exception("no usable Manager found",
+                               Cr.NS_ERROR_NOT_IMPLEMENTED);
+  }


Actually to be honest, when would we fail? It should never happen except syntax failures in the ExtensionManager class we would see in either way. I don't see a reason for the else case here.

…tion

…stense check

xabolcs · 2012-07-09T20:17:13Z

@whimboo:
added commits with changes:

strict checks: === and !==
do not define manager at L50:
not checking the existence of manager near L57: else is removed by Your comments, if is removed because I would avoid silent fails if something is wrong near before.

whimboo · 2012-08-26T19:12:51Z

extension/chrome/content/aboutNightly/aboutNightly.js

+var ExtensionManager = {
+  getAddonByID: function (aID, aCallback) {
+    if (!aID || typeof aID !== "string")
+      throw Components.Exception("aID must be a non-empty string",


Reading through the docs for Components.Exception it tells me that those should be used for XPCOM components. Here we do not have a XPCOM component implemented in JS so I think we should better throw an Error.

I decided to use Components.Exception based on Bug 757663 comment 3, to be consistent with AddonManager. For the details see Bug 759642!

Chatted with unfocused about it and as he mentioned we can even safely make use of Components.Exception in our js modules. So we are good here.

whimboo · 2012-08-26T19:18:08Z

With the remaining items fixed we will have a good template for coding styles and we can get the code checked-in. Thanks in advance for the update.

whimboo · 2012-09-19T10:18:02Z

@xabolcs, would you mind to fix the remaining nits? I kinda would like to get this pushed soon.

xabolcs · 2012-09-19T11:03:40Z

whimboo commented:

@xabolcs, would you mind to fix the remaining nits? I kinda would like to get this pushed soon.

I try my best, but I'm currently busy so not sure if I could provide an update this week.

whimboo · 2012-09-19T11:21:09Z

No worries. Whenever you have time. Thanks!

- if brackets - aCurrentItem

xabolcs · 2012-09-26T00:52:25Z

@whimboo, 5th set of commits added.

whimboo · 2012-09-26T20:36:08Z

Just tested and it looks great! I'm going to merge it now.

whimboo · 2012-09-26T20:38:08Z

3368984

xabolcs added 4 commits June 12, 2012 05:04

Issue mozilla#58 - Part 1: move aboutNightly.xhtml to it's own directory

a44d78a

--HG-- rename : extension/chrome/content/aboutNightly.xhtml => extension/chrome/content/aboutNightly/aboutNightly.xhtml

Issue mozilla#58 - Part 2: fill Contributors automatically by retriev…

e74bc0e

…ing those from the install.rdf

Issue mozilla#58 - Part 3: fix Songbird look

f5138ad

Issue mozilla#58 - Part 4: fix NTT links

36e771c

whimboo reviewed Jun 14, 2012
View reviewed changes

Issue mozilla#58 - addressing comments part 2

451897b

- ADDON_ID - haveAM

whimboo mentioned this pull request Jun 19, 2012

No looping callback in getExtensionList() with Gecko 1.9.x. Fixes #88. #89

Closed

whimboo reviewed Jun 19, 2012
View reviewed changes

Issue mozilla#58 - addressing comments part 3: manager

d991c7f

xabolcs mentioned this pull request Jun 19, 2012

Implement nttAddonManager.jsm - an AddonManager / Extension Manager wrapper #90

Closed

whimboo reviewed Jul 2, 2012
View reviewed changes

xabolcs added 2 commits July 9, 2012 21:59

Issue mozilla#58 - addressing comments part 4: coding style, redefini…

8377852

…tion

Issue mozilla#58 - addressing comments part 4 and a half: manager exi…

88512e8

…stense check

whimboo reviewed Aug 26, 2012
View reviewed changes

Issue mozilla#58 - addressing comments part 5:

4e7181b

- if brackets - aCurrentItem

xabolcs added a commit that referenced this pull request Sep 26, 2012

Update 'Contributors' section automatically in about:nightly (#85)

3368984

whimboo closed this Sep 26, 2012

whimboo mentioned this pull request Sep 26, 2012

Update list of contributors in 'about:nightly' #58

Closed

xabolcs mentioned this pull request Oct 11, 2012

Prepare to release version 3.4. Helps to fix Issue #95. #97

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update 'Contributors' section automatically in about:nightly. Fixes #58. #85

Update 'Contributors' section automatically in about:nightly. Fixes #58. #85

xabolcs commented Jun 12, 2012

whimboo Jun 14, 2012

xabolcs Jun 15, 2012

whimboo commented Jun 18, 2012

whimboo Jun 19, 2012

xabolcs Jun 19, 2012

whimboo Jun 19, 2012

xabolcs commented Jun 19, 2012

whimboo commented Jun 19, 2012

xabolcs commented Jun 19, 2012

xabolcs commented Jun 19, 2012

whimboo Jul 2, 2012

whimboo Jul 2, 2012

xabolcs commented Jul 9, 2012

whimboo Aug 26, 2012

xabolcs Aug 27, 2012

whimboo Sep 19, 2012

whimboo commented Aug 26, 2012

whimboo commented Sep 19, 2012

xabolcs commented Sep 19, 2012

whimboo commented Sep 19, 2012

xabolcs commented Sep 26, 2012

whimboo commented Sep 26, 2012

whimboo commented Sep 26, 2012

Update 'Contributors' section automatically in about:nightly. Fixes #58. #85

Update 'Contributors' section automatically in about:nightly. Fixes #58. #85

Conversation

xabolcs commented Jun 12, 2012

Choose a reason for hiding this comment

Choose a reason for hiding this comment

whimboo commented Jun 18, 2012

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xabolcs commented Jun 19, 2012

whimboo commented Jun 19, 2012

xabolcs commented Jun 19, 2012

xabolcs commented Jun 19, 2012

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xabolcs commented Jul 9, 2012

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

whimboo commented Aug 26, 2012

whimboo commented Sep 19, 2012

xabolcs commented Sep 19, 2012

whimboo commented Sep 19, 2012

xabolcs commented Sep 26, 2012

whimboo commented Sep 26, 2012

whimboo commented Sep 26, 2012