This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
Tooltips are missing from the formatting option buttons #72
Labels
enhancement
Things that are nice to have but not critical
Milestone
Comments
|
@SoftVision-EmilPasca good find, thank you!
|
cedricium
added a commit
to cedricium/notes
that referenced
this issue
Jul 2, 2017
This commit is a quick fix to issue mozilla#72 - missing tooltips. Currently, Quill has no support for native tooltips, rather relying on Bootstrap (which requires jQuery). For usuability purposes, I've added titles to the toolbar buttons which appear when hovering over the buttons, similar to a tooltip but not as styled. The titles themselves include the button's functionality ('Font size', 'Bold', 'Bulleted list', etc.) as well as the key-binding associated with it. Currently, only the 'Bold' and 'Italic' formats included a default key-binding. Following the documentation for adding additional bindings to the keyboard module (found here: https://quilljs.com/docs/modules/keyboard/), I went ahead and added three bindings for the buttons/formats in the toolbar without them ('strike', 'list: ordered', 'list: bulleted'). By determining the user's operating system, the titles display the appropriate key for the binding sequence (either Mac's Cmd symbol or 'Ctrl').
|
I tried adding tooltips as shown in the reference but then realized that effect is only possible using Bootstrap (see this Quill issue: slab/quill#650). I went ahead and instead added titles to the buttons which shows the function name and the key-binding for that specific function. In addition to the titles, I added three key-bindings for the 'strike', 'numbered list', and 'bulleted list' formats since Quill does not have default bindings for them. In my excitement to try and fix this issue I forgot to ask if I could give this a shot so hopefully it'll be alright. I've made a PR with my changes. |
cedricium
added a commit
to cedricium/notes
that referenced
this issue
Jul 4, 2017
Revision to my other pull-request (mozilla#121). ESLint issues have been resolved. This is a fix for the missing tooltips on the toolbar buttons. The button titles were added to `locales/en-US/notes.properties` in order to be translated for the supported languages. `panel.js` makes use of `i18n.getMessage()` in order to fetch titles.
|
The issue is no longer reproducible on the latest Firefox Notes version (1.5.0dev built on 07/07/2017). |
Natim
pushed a commit
that referenced
this issue
Jul 10, 2017
This commit is a quick fix to issue #72 - missing tooltips. Currently, Quill has no support for native tooltips, rather relying on Bootstrap (which requires jQuery). For usuability purposes, I've added titles to the toolbar buttons which appear when hovering over the buttons, similar to a tooltip but not as styled. The titles themselves include the button's functionality ('Font size', 'Bold', 'Bulleted list', etc.) as well as the key-binding associated with it. Currently, only the 'Bold' and 'Italic' formats included a default key-binding. Following the documentation for adding additional bindings to the keyboard module (found here: https://quilljs.com/docs/modules/keyboard/), I went ahead and added three bindings for the buttons/formats in the toolbar without them ('strike', 'list: ordered', 'list: bulleted'). By determining the user's operating system, the titles display the appropriate key for the binding sequence (either Mac's Cmd symbol or 'Ctrl').
vladikoff
pushed a commit
that referenced
this issue
Jul 11, 2017
* Titles and key-bindings for toolbar buttons This commit is a quick fix to issue #72 - missing tooltips. Currently, Quill has no support for native tooltips, rather relying on Bootstrap (which requires jQuery). For usuability purposes, I've added titles to the toolbar buttons which appear when hovering over the buttons, similar to a tooltip but not as styled. The titles themselves include the button's functionality ('Font size', 'Bold', 'Bulleted list', etc.) as well as the key-binding associated with it. Currently, only the 'Bold' and 'Italic' formats included a default key-binding. Following the documentation for adding additional bindings to the keyboard module (found here: https://quilljs.com/docs/modules/keyboard/), I went ahead and added three bindings for the buttons/formats in the toolbar without them ('strike', 'list: ordered', 'list: bulleted'). By determining the user's operating system, the titles display the appropriate key for the binding sequence (either Mac's Cmd symbol or 'Ctrl'). * Fix linter.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
[Affected versions]:
[Affected Platforms]:
[Prerequisites]:
[Steps to reproduce]:
[Expected result]:
[Actual result]:
[Notes]:
The text was updated successfully, but these errors were encountered: