Skip to content

[Editor] Add editors with a comment in the sidebar #20217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2025
Merged

[Editor] Add editors with a comment in the sidebar #20217

merged 1 commit into from
Aug 31, 2025

Conversation

calixteman
Copy link
Contributor

and add a button close to the editor.
Clicking on the button will display a popup with the comment but it's for a next patch.

@calixteman calixteman force-pushed the comment_editor_sidebar branch from e3c770f to b8b7243 Compare August 31, 2025 09:57
@timvandermeij
Copy link
Contributor

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/76523d91d1855bc/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/76523d91d1855bc/output.txt

Total script time: 0.96 mins

Published

timvandermeij
timvandermeij approved these changes Aug 31, 2025
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with the comments addressed. Thank you!

@calixteman
[Editor] Add editors with a comment in the sidebar
2a45985 
and add a button close to the editor.
Clicking on the button will display a popup with the comment but it's for a next patch.
@calixteman calixteman force-pushed the comment_editor_sidebar branch from b8b7243 to 2a45985 Compare August 31, 2025 17:59
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c103676a62bc264/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/24db8f3984d8d14/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/c103676a62bc264/output.txt

Total script time: 18.08 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/24db8f3984d8d14/output.txt

Total script time: 39.44 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit c8d49db into mozilla:master Aug 31, 2025
9 checks passed
@calixteman calixteman deleted the comment_editor_sidebar branch August 31, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @timvandermeij @moz-tools-bot